Handmade Hero » Forums » Code » Having an issue with Day 5
skoepa
6 posts
#15484 Having an issue with Day 5
3 months, 2 weeks ago Edited by skoepa on June 4, 2018, 10:32 p.m. Reason: Initial post

Hello I have the exact same code as Casey does on Day 5, but it will not work for me as it gives me an unhandled exception error on line 62. I am at a complete loss as to what to do.

This is my callstack

1
2
3
4
5
>	win32_handmade.exe!Win32ResizeDIBSection(int Width, int Height) Line 62	C++
 	win32_handmade.exe!WIN32MainWindowCallback(HWND__ * Window, unsigned int Message, unsigned int WParam, long LParam) Line 118	C++
 	[External Code]	
 	win32_handmade.exe!WinMain(HINSTANCE__ * hInstance, HINSTANCE__ * PrevInstance, char * CommandLine, int ShowCode) Line 184	C++
 	[External Code]	


mmozeiko
Mārtiņš Možeiko
1792 posts / 1 project
#15486 Having an issue with Day 5
3 months, 2 weeks ago Edited by Mārtiņš Možeiko on June 4, 2018, 10:39 p.m.

In Day 5 code line 62 is a comment line in RenderWeirdGradient function. There is no way it can crash.

Please show exact code you are using, I'm guessing you either changed something too much or forgot to change something for it to work.
skoepa
6 posts
#15489 Having an issue with Day 5
3 months, 2 weeks ago

  1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
/* ========================================================================
   $File: $
   $Date: $
   $Revision: $
   $Creator: Casey Muratori $
   $Notice: (C) Copyright 2014 by Molly Rocket, Inc. All Rights Reserved. $
   ======================================================================== */

#include <windows.h>
#include <stdint.h>

#define internal static 
#define local_persist static 
#define global_variable static

typedef int8_t int8;
typedef int16_t int16;
typedef int32_t int32;
typedef int64_t int64;

typedef uint8_t uint8;
typedef uint16_t uint16;
typedef uint32_t uint32;
typedef uint64_t uint64;

struct win32_offscreen_buffer
{
    // NOTE(casey): Pixels are alwasy 32-bits wide, Memory Order BB GG RR XX
    BITMAPINFO Info;
    void *Memory;
    int Width;
    int Height;
    int Pitch;
};

struct win32_window_dimension
{
    int Width;
    int Height;
};

// TODO(casey): This is a global for now.
global_variable bool GlobalRunning;
global_variable win32_offscreen_buffer GlobalBackbuffer;

win32_window_dimension
Win32GetWindowDimension(HWND Window)
{
    win32_window_dimension Result;
    
    RECT ClientRect;
    GetClientRect(Window, &ClientRect);
    Result.Width = ClientRect.right - ClientRect.left;
    Result.Height = ClientRect.bottom - ClientRect.top;

    return(Result);
}

internal void
RenderWeirdGradient(win32_offscreen_buffer Buffer, int BlueOffset, int GreenOffset)
{
    // TODO(casey): Let's see what the optimizer does

    uint8 *Row = (uint8 *)Buffer.Memory;    
    for(int Y = 0;
        Y < Buffer.Height;
        ++Y)
    {
        uint32 *Pixel = (uint32 *)Row;
        for(int X = 0;
            X < Buffer.Width;
            ++X)
        {
            uint8 Blue = (X + BlueOffset);
            uint8 Green = (Y + GreenOffset);

            *Pixel++ = ((Green << 8) | Blue);
        }
        
        Row += Buffer.Pitch;
    }
}

internal void
Win32ResizeDIBSection(win32_offscreen_buffer *Buffer, int Width, int Height)
{
    // TODO(casey): Bulletproof this.
    // Maybe don't free first, free after, then free first if that fails.

    if(Buffer->Memory)
    {
        VirtualFree(Buffer->Memory, 0, MEM_RELEASE);
    }

    Buffer->Width = Width;
    Buffer->Height = Height;

    int BytesPerPixel = 4;

    // NOTE(casey): When the biHeight field is negative, this is the clue to
    // Windows to treat this bitmap as top-down, not bottom-up, meaning that
    // the first three bytes of the image are the color for the top left pixel
    // in the bitmap, not the bottom left!
    Buffer->Info.bmiHeader.biSize = sizeof(Buffer->Info.bmiHeader);
    Buffer->Info.bmiHeader.biWidth = Buffer->Width;
    Buffer->Info.bmiHeader.biHeight = -Buffer->Height;
    Buffer->Info.bmiHeader.biPlanes = 1;
    Buffer->Info.bmiHeader.biBitCount = 32;
    Buffer->Info.bmiHeader.biCompression = BI_RGB;

    // NOTE(casey): Thank you to Chris Hecker of Spy Party fame
    // for clarifying the deal with StretchDIBits and BitBlt!
    // No more DC for us.
    int BitmapMemorySize = (Buffer->Width*Buffer->Height)*BytesPerPixel;
    Buffer->Memory = VirtualAlloc(0, BitmapMemorySize, MEM_COMMIT, PAGE_READWRITE);
    Buffer->Pitch = Width*BytesPerPixel;

    // TODO(casey): Probably clear this to black
}

internal void
Win32DisplayBufferInWindow(HDC DeviceContext,
                           int WindowWidth, int WindowHeight,
                           win32_offscreen_buffer Buffer)
{
    // TODO(casey): Aspect ratio correction
    // TODO(casey): Play with stretch modes
    StretchDIBits(DeviceContext,
                  /*
                  X, Y, Width, Height,
                  X, Y, Width, Height,
                  */
                  0, 0, WindowWidth, WindowHeight,
                  0, 0, Buffer.Width, Buffer.Height,
                  Buffer.Memory,
                  &Buffer.Info,
                  DIB_RGB_COLORS, SRCCOPY);
}

LRESULT CALLBACK
Win32MainWindowCallback(HWND Window,
                        UINT Message,
                        WPARAM WParam,
                        LPARAM LParam)
{       
    LRESULT Result = 0;

    switch(Message)
    {
        case WM_CLOSE:
        {
            // TODO(casey): Handle this with a message to the user?
            GlobalRunning = false;
        } break;

        case WM_ACTIVATEAPP:
        {
            OutputDebugStringA("WM_ACTIVATEAPP\n");
        } break;

        case WM_DESTROY:
        {
            // TODO(casey): Handle this as an error - recreate window?
            GlobalRunning = false;
        } break;
        
        case WM_PAINT:
        {
            PAINTSTRUCT Paint;
            HDC DeviceContext = BeginPaint(Window, &Paint);
            win32_window_dimension Dimension = Win32GetWindowDimension(Window);
            Win32DisplayBufferInWindow(DeviceContext, Dimension.Width, Dimension.Height,
                                       GlobalBackbuffer);
            EndPaint(Window, &Paint);
        } break;

        default:
        {
//            OutputDebugStringA("default\n");
            Result = DefWindowProc(Window, Message, WParam, LParam);
        } break;
    }
    
    return(Result);
}

int CALLBACK
WinMain(HINSTANCE Instance,
        HINSTANCE PrevInstance,
        LPSTR CommandLine,
        int ShowCode)
{
    WNDCLASS WindowClass = {};

    Win32ResizeDIBSection(&GlobalBackbuffer, 1280, 720);
    
    WindowClass.style = CS_HREDRAW|CS_VREDRAW|CS_OWNDC;
    WindowClass.lpfnWndProc = Win32MainWindowCallback;
    WindowClass.hInstance = Instance;
//    WindowClass.hIcon;
    WindowClass.lpszClassName = "HandmadeHeroWindowClass";

    if(RegisterClassA(&WindowClass))
    {
        HWND Window =
            CreateWindowExA(
                0,
                WindowClass.lpszClassName,
                "Handmade Hero",
                WS_OVERLAPPEDWINDOW|WS_VISIBLE,
                CW_USEDEFAULT,
                CW_USEDEFAULT,
                CW_USEDEFAULT,
                CW_USEDEFAULT,
                0,
                0,
                Instance,
                0);
        if(Window)
        {
            // NOTE(casey): Since we specified CS_OWNDC, we can just
            // get one device context and use it forever because we
            // are not sharing it with anyone.
            HDC DeviceContext = GetDC(Window);

            int XOffset = 0;
            int YOffset = 0;

            GlobalRunning = true;
            while(GlobalRunning)
            {
                MSG Message;

                while(PeekMessage(&Message, 0, 0, 0, PM_REMOVE))
                {
                    if(Message.message == WM_QUIT)
                    {
                        GlobalRunning = false;
                    }
                    
                    TranslateMessage(&Message);
                    DispatchMessageA(&Message);
                }

                RenderWeirdGradient(GlobalBackbuffer, XOffset, YOffset);

                win32_window_dimension Dimension = Win32GetWindowDimension(Window);
                Win32DisplayBufferInWindow(DeviceContext, Dimension.Width, Dimension.Height,
                                           GlobalBackbuffer);
                
                ++XOffset;
                YOffset += 2;
            }
        }
        else
        {
            // TODO(casey): Logging
        }
    }
    else
    {
        // TODO(casey): Logging
    }
    
    return(0);
}


This is the full code I have.
bewwys
11 posts

Hi,
I'm bewwys I'm a student at the 42 codingschool . I'm glad to be here. I'm a noob so please take care of me :)

#15490 Having an issue with Day 5
3 months, 2 weeks ago

Hi,

I'm wondering why in your callstack the function is define like this

Win32ResizeDIBSection(int Width, int Height)

but in your source code the function is like that

Win32ResizeDIBSection(win32_offscreen_buffer *Buffer, int Width, int Height) ?
skoepa
6 posts
#15491 Having an issue with Day 5
3 months, 2 weeks ago

bewwys
Hi,

I'm wondering why in your callstack the function is define like this

Win32ResizeDIBSection(int Width, int Height)

but in your source code the function is like that

Win32ResizeDIBSection(win32_offscreen_buffer *Buffer, int Width, int Height) ?


That's weird, it's like it's ignoring it or something.
mmozeiko
Mārtiņš Možeiko
1792 posts / 1 project
#15493 Having an issue with Day 5
3 months, 2 weeks ago

My suspicion is that you are running exe that is compiled from very different source code than you posted. Because line 62 is not inside Win32ResizeDIBSection function as call stack indicates. And also bewwys already mentioned - arguments to Win32ResizeDIBSection function are different from source code.

Verify where is your exe file and is it really the one you are compiling.
skoepa
6 posts
#15494 Having an issue with Day 5
3 months, 2 weeks ago

mmozeiko
My suspicion is that you are running exe that is compiled from very different source code than you posted. Because line 62 is not inside Win32ResizeDIBSection function as call stack indicates. And also bewwys already mentioned - arguments to Win32ResizeDIBSection function are different from source code.

Verify where is your exe file and is it really the one you are compiling.


I'm pretty sure that's the reason actually, do you know how I can fix that?
mmozeiko
Mārtiņš Možeiko
1792 posts / 1 project
#15495 Having an issue with Day 5
3 months, 2 weeks ago Edited by Mārtiņš Možeiko on June 5, 2018, 7:05 a.m.

Umm.. by debugging executable that is produced in correct place?

Basically:
1) compile to c:\whatever\file.exe
2) debug c:\whatever\file.exe (and not c:\other\location\file.exe)

Its impossible to answer without knowing what are you doing. You are asking "I want to eat oranges, but I'm eating apples. How to eat oranges?" Answer is "eat oranges, don't eat apples" :D
skoepa
6 posts
#15496 Having an issue with Day 5
3 months, 2 weeks ago Edited by skoepa on June 5, 2018, 7:17 a.m.

Something is just super wonky about my file, and I don't know enough to know how to fix it.

I think I messed something up when I saved it in emacs because now when I click in it it says the app cannot run on my PC.

Whenever I tried to open it in visual studio it would say attach and I don't know what to attach it to.

Edit: I'm really sorry for sounding dumb I am just so incredibly lost because I clearly screwed something up badly.
mmozeiko
Mārtiņš Možeiko
1792 posts / 1 project
#15497 Having an issue with Day 5
3 months, 2 weeks ago Edited by Mārtiņš Možeiko on June 5, 2018, 8:16 a.m.

Try without emacs just to get basics done. Open new cmd.exe, run vcvarsall.bat. Then run "cl.exe ..other..argumens.. file.cpp /Feoutput.exe" to get output.exe. And then run "devenv output.exe" and check if you can debug correctly. If you can then do small modification and try again. Repeat until you set up configuration/environment you like to use.

Whenever I tried to open it in visual studio it would say attach and I don't know what to attach it to.
What is "it"? How do you open "it"?
skoepa
6 posts
#15499 Having an issue with Day 5
3 months, 2 weeks ago Edited by skoepa on June 5, 2018, 4:40 p.m.

yooo that fixed it. Thank you so much!

Edit: I'm still having the attach issue, when I open the .cpp instead of start it just says to attach it to a process